CP-54010: Use xapi for ssh in xsconsole#53
Merged
BengangY merged 1 commit intoxapi-project:feature/configure-sshfrom Mar 27, 2025
Merged
CP-54010: Use xapi for ssh in xsconsole#53BengangY merged 1 commit intoxapi-project:feature/configure-sshfrom
BengangY merged 1 commit intoxapi-project:feature/configure-sshfrom
Conversation
liulinC
reviewed
Mar 21, 2025
| self.session.xenapi.host.disable(self.host.opaqueref()) | ||
|
|
||
| def EnableSSH(self): | ||
| self.session.xenapi.host.enable_ssh(self.host.opaqueref()) |
Collaborator
There was a problem hiding this comment.
is xapi enable_ssh actually start the service?
Contributor
Author
There was a problem hiding this comment.
Yes, it will start and enable sshd service.
gangj
reviewed
Mar 25, 2025
| self.RequireSession() | ||
| self.session.xenapi.host.disable(self.host.opaqueref()) | ||
|
|
||
| def EnableSSH(self): |
There was a problem hiding this comment.
It might be clearer to rename it like: EnableSSHOnLocalHost.
Contributor
Author
There was a problem hiding this comment.
All the functions in this file are for the local host. And as I understand, xsconsole is used for the local host's configuration. So I think OnlocalHost is a bit redundant.
gangj
approved these changes
Mar 25, 2025
psafont
approved these changes
Mar 25, 2025
GeraldEV
reviewed
Mar 25, 2025
Currently, xsconsole uses systemd to manage ssh service. In the ssh configuration feature (CP-50702), ssh's status is saved in xapi DB and is updated by xapi API. So change the way of managing ssh to xapi API in xsconsole to keep the ssh's status updating. Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
BengangY
force-pushed
the
private/bengangy/CP-54010
branch
from
f5762b8 to
c6a19f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, xsconsole uses systemd to manage ssh service. In the ssh configuration feature (CP-50702), ssh's status is saved in xapi DB and is updated by xapi API.
So change the way of managing ssh to xapi API in xsconsole to keep the ssh's status updating.