Miscellaneous IPv6 fixes and cleanup#6421
Merged
last-genius merged 4 commits intoxapi-project:masterfrom Apr 16, 2025
Merged
Conversation
Otherwise, for a pool.conf like `slave:2a01:240:ab08:5:13::201`, `address` would just be `2a01`. Note that such `address` isn't actually used anywhere (only the user-specified address is written to the config, and that isn't truncated), so this is just a safety measure in case of future changes. Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
Use a helper method to parse lists in values, and use options better to ignore empty values. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Other parts of xapi and various scripts have already been updated to account for IPv6 entries in management.conf (like xe-reset-networking, xapi_pool.ml, etc.) Add the IPv6 alternatives to IPv4 config entries also to read_management_conf, otherwise networkd will not properly account for IPv6 settings or error out in case some IPv4 entries are skipped Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
psafont
reviewed
Apr 11, 2025
psafont
approved these changes
Apr 11, 2025
lindig
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR,
xapiandxcp-networkdnow properly handle emergency network resets on an IPv6-only host (when it's an individual host as well as when it's in a pool as a supporter and as a coordinator)Tested manually, see also the required
xsconsolePR: xapi-project/xsconsole#55.