Fix qmlformat script for newer Arch - #5229
Conversation
|
Download the latest artifacts for this pull request: |
|
@wwmm could you take a look at it? Thanks! |
|
As the scripts and flatpak files being touched were written by @vchernin it would probably be better if he reviewed these changes. Here on my Arch Linux installation the qml scripts seem fine. Qml's linter does complain about But that looks more like a bug in the linter than in the scripts. Our CI job does fail because of it. But I was waiting for Qt 6.12 before deciding what to do about it. Sometimes the flatpak external data checker job fails. If that is the better way to fix the problem I don't know. |
|
The qmllint and qmlformat scripts are hacks to begin with, so any changes to make them more reliable seem fine to me. But clearly distros need to do a better job here if we now have 3 possible binary names… I would suggest that The fix for the Flatpak job makes a bit of sense but is also a bit puzzling. We should be passing the CI provided GITHUB_TOKEN environment variable and so Flatpak external data checker should only be making authenticated API calls. Those should surely not be hitting any GitHub API limit. But if this indeed works more reliably I guess it’s fine. |
2adea64 to
218fcaa
Compare
Fix bugs in qmlformat/qmllint scripts
util: prefer -qt6 qml binaries before /usr/lib/qt6 fallback
218fcaa to
f80c4dc
Compare
|
@vchernin could you take another look at it? Thanks! |
|
The qmllint and qmlformat scripts look fine now, thanks. I understand removing the github actions API usage from the flatpak modules, but why the anitya (release-monitoring.org) ones as well? Anitya is preferable to just getting the github tags, as it can filter out non-stable releases properly. Is anitya also unreliable these days? |
This pull request fixes the failing QML format job by adding a command fallback since the binary location changed on Arch Linux. It also updates the flatpak external data checker configuration for libebur128 to use git tags instead of GitHub releases, avoiding API rate limits that caused the Flatpak lint job to fail.