Skip to content

Error modal hygiene #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tadast merged 2 commits into from
Nov 14, 2025
Merged

Error modal hygiene #839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f955913
Do not show backtrace in prod
tadast Nov 14, 2025
8b82deb
Typo
tadast Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lib/sequenceserver/routes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,11 +291,9 @@ class Routes < Sinatra::Base
error.class.name
end

# If error object has a more_info method, use that. If the error does not
# have more_info, use backtrace.join("\n") as more_info.
if error.respond_to? :more_info
if error.respond_to?(:more_info)
error_data[:more_info] = error.more_info
elsif error.respond_to? :backtrace
elsif error.respond_to?(:backtrace) && !settings.production?
error_data[:more_info] = error.backtrace.join("\n")
end

Expand Down
2 changes: 1 addition & 1 deletion views/error.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="container">
<h1>An error has occured</h1>
<h1>An error has occurred</h1>
<h1><%= error_data[:title] %></h1>

<p><%= error_data[:message] %></p>
Expand Down
Loading