add widget by wuan · Pull Request #210 · wuan/bo-android

wuan · 2020-06-05T20:19:58Z

This is closing #45

# Conflicts: # app/src/main/java/org/blitzortung/android/alert/handler/AlertHandler.kt # app/src/main/java/org/blitzortung/android/app/WidgetProvider.kt

sonarqubecloud · 2025-11-30T00:30:55Z

Quality Gate failed

Failed conditions
5.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copilot

Pull request overview

Adds an Android home-screen widget that renders the existing AlarmView in the background via WorkManager, alongside build/tooling upgrades to support the new setup.

Changes:

Introduces WidgetProvider + WidgetUpdateWorker and wires them into the manifest / Dagger graph.
Adds widget resources (provider XML, layout, preview drawable) and small rendering tweaks for widget sizing.
Updates Gradle/AGP + related build configuration and bumps app version.

Reviewed changes

Copilot reviewed 24 out of 25 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
gradle/wrapper/gradle-wrapper.properties	Updates Gradle wrapper distribution.
gradle.properties	Adjusts Android/AGP-related Gradle properties for the new toolchain.
build.gradle.kts	Updates top-level plugin versions and detekt/ktlint configuration.
app/build.gradle.kts	Updates app version, kapt configuration, and dependency versions.
app/src/main/AndroidManifest.xml	Enables the widget receiver in the manifest (receiver definition updated).
app/src/main/java/org/blitzortung/android/app/BOApplication.kt	Exposes the Dagger `AppComponent` instance for non-Activity entry points (worker/widget).
app/src/main/java/org/blitzortung/android/app/Main.kt	Moves `StrikeColorHandler` construction to DI.
app/src/main/java/org/blitzortung/android/app/WidgetProvider.kt	AppWidgetProvider now schedules immediate + periodic WorkManager updates.
app/src/main/java/org/blitzortung/android/app/WidgetUpdateWorker.kt	New worker that renders `AlarmView` to a bitmap and pushes RemoteViews updates.
app/src/main/java/org/blitzortung/android/alert/Warning.kt	Updates `LocalActivity.toString()` formatting and handles “no distance” case.
app/src/main/java/org/blitzortung/android/util/MeasurementSystem.kt	Adds `unitSymbol` used for widget/status text formatting.
app/src/test/java/org/blitzortung/android/alert/AlertResultTest.kt	Adds unit tests for `LocalActivity.toString()` output.
app/src/main/res/layout/widget.xml	Updates widget layout to include a status/update-time text line.
app/src/main/res/xml/widget_provider.xml	Updates widget provider metadata (preview, resize, update period).
app/src/main/res/drawable/widget_preview.xml	Adds a widget preview vector asset.
app/src/main/res/drawable/rounded_box.xml	Adjusts widget background styling (fill/corners/stroke).
app/src/main/res/values/strings.xml	Updates copyright year.
app/src/main/java/org/blitzortung/android/dagger/module/ActivityBindingModule.kt	Adds injector binding for `WidgetProvider`.
app/src/main/java/org/blitzortung/android/dagger/component/AppComponent.kt	Exposes dependencies needed by the widget worker via component methods.
app/src/main/java/org/blitzortung/android/map/overlay/color/StrikeColorHandler.kt	Makes `StrikeColorHandler` injectable (`@Inject`, `@Singleton`).
app/src/main/java/org/blitzortung/android/data/MainDataHandler.kt	Exposes `dataProvider` with a private setter.
app/src/main/java/org/blitzortung/android/app/view/support/CanvasProvider.kt	Adds dimension guard + adjusts `CanvasWrapper` properties.
app/src/main/java/org/blitzortung/android/app/view/alarm/LocalActivityRenderer.kt	Minor paint/text sizing adjustments used by the renderer.

Comments suppressed due to low confidence (1)

app/src/main/java/org/blitzortung/android/app/view/support/CanvasProvider.kt:23

CanvasProvider.provide() caches the first CanvasWrapper it creates and returns it for all subsequent calls, even if the requested width/height change (e.g., after a view resize). This can lead to drawing into a bitmap with stale dimensions. Recreate the cached CanvasWrapper whenever the requested size differs from the existing one (and consider handling background color changes similarly if needed).

    fun provide(backgroundColor: Int, width: Int, height: Int): CanvasWrapper? {
        if (width <= 0 || height <= 0) {
            return null
        }
        if (canvas == null) {
            canvas = CanvasWrapper(width, height, backgroundColor)
        }
        return canvas

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 24 out of 25 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sonarqubecloud · 2026-04-18T15:06:10Z

Quality Gate failed

Failed conditions
1 Security Hotspot
20.3% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copilot

Pull request overview

Copilot reviewed 31 out of 32 changed files in this pull request and generated 17 comments.

Comments suppressed due to low confidence (1)

app/src/main/java/org/blitzortung/android/app/view/support/CanvasProvider.kt:24

CanvasProvider caches a single CanvasWrapper but never recreates it when the requested width/height change (and it also ignores updated backgroundColor). This can render incorrectly after a resize (e.g., widget resize / view re-measure). Consider recreating the cached CanvasWrapper when dimensions or background color differ from the cached instance.

    fun provide(backgroundColor: Int, width: Int, height: Int): CanvasWrapper? {
        if (width <= 0 || height <= 0) {
            return null
        }
        if (canvas == null) {
            canvas = CanvasWrapper(width, height, backgroundColor)
        }
        return canvas
    }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-18T16:48:47Z

+        val location = worker.testGetLastKnownLocation()
+
+        assertThat(location).isNotNull
+        assertThat(location!!.latitude).isEqualTo(51.0)
+        assertThat(location.longitude).isEqualTo(7.0)
+    }


assertThat(location).isNotNull is not invoking an assertion; in Kotlin this is just a method reference expression and won’t fail the test if location is null. Call the assertion method (or use a proper non-null assertion pattern) so the test actually verifies the behavior.

Copilot · 2026-04-18T16:48:47Z

+    fun workerClassIsOpen() {
+        val workerClass = WidgetUpdateWorker::class.java
+        val modifiers = workerClass.modifiers
+        val isPublic = java.lang.reflect.Modifier.isPublic(modifiers)
+        assertThat(isPublic).isTrue()
+    }


This test is named workerClassIsOpen but it only asserts the class is public. open in Kotlin corresponds to “not final”; if you want to test openness, assert !Modifier.isFinal(modifiers) (or rename the test to reflect what it checks).

Copilot · 2026-04-18T16:48:47Z

@@ -45,4 +45,41 @@ class AlertResultTest {
        assertThat(uut.bearingName).isEqualTo("foo")
        assertThat(uut.sectorWithClosestStrike).isNotNull


assertThat(uut.sectorWithClosestStrike).isNotNull does not execute an assertion (it’s a method reference expression in Kotlin), so this test won’t fail if the value is null. Invoke the assertion method (or use another explicit non-null assertion) so the test actually verifies the condition.

Suggested change

assertThat(uut.sectorWithClosestStrike).isNotNull

assertThat(uut.sectorWithClosestStrike).isNotNull()

Copilot · 2026-04-18T16:48:47Z

+        <receiver
+            android:name=".WidgetProvider"
+            android:exported="true">
+            <meta-data
+                android:name="android.appwidget.provider"
+                android:resource="@xml/widget_provider" />
            <intent-filter>
                <action android:name="android.appwidget.action.APPWIDGET_UPDATE" />
            </intent-filter>
-        </receiver>-->
+        </receiver>


WidgetProvider is exported without restricting who can send APPWIDGET_UPDATE. Add android:permission="android.permission.BIND_APPWIDGET" on the receiver (common pattern for widgets) to prevent other apps from triggering your update logic via broadcasts.

Copilot · 2026-04-18T16:48:48Z

+        val isPublic = java.lang.reflect.Modifier.isPublic(modifiers)
+        assertThat(isPublic).isTrue()


This test is named widgetProviderIsOpen but it only asserts the class is public. If the intent is to ensure it’s non-final (open), assert !Modifier.isFinal(modifiers) (or rename the test).

Suggested change

val isPublic = java.lang.reflect.Modifier.isPublic(modifiers)

assertThat(isPublic).isTrue()

val isOpen = !java.lang.reflect.Modifier.isFinal(modifiers)

assertThat(isOpen).isTrue()

Copilot · 2026-04-18T16:48:49Z

+
+### Coroutines Testing
+- **kotlinx-coroutines-test 1.9.0** - Test coroutines with virtual time
+- **Turbine 1.2.0** - Flow testing made easy


This testing guide lists library versions that don’t match the versions declared in app/build.gradle.kts (e.g., AssertJ/MockK/Robolectric/coroutines-test). Please update the documented versions (or remove the specific version numbers) to keep the guide accurate.

Suggested change

- **Turbine 1.2.0** - Flow testing made easy

- **Turbine** - Flow testing made easy

Copilot · 2026-04-18T16:48:49Z

+    override fun onUpdate(context: Context, appWidgetManager: AppWidgetManager, appWidgetIds: IntArray) {
+        super.onUpdate(context, appWidgetManager, appWidgetIds)
+        Log.v(Main.LOG_TAG, "WidgetProvider.onUpdate() - re-rendering with new size")
+        scheduleImmediateUpdate(context)
+        scheduleNextUpdate(context)
+    }


Widget updates are scheduled but this provider never sets up the widget RemoteViews (e.g., click PendingIntent) in onUpdate/onEnabled. That means the widget can be non-interactive until WidgetUpdateWorker runs (and if the worker is deferred by constraints, clicks do nothing). Consider setting the click PendingIntent (and any static view state) here and using the worker only for rendering/updating the bitmap/text.

Copilot · 2026-04-18T16:48:49Z

+        // Get location mode from preferences
+        val preferences = PreferenceManager.getDefaultSharedPreferences(applicationContext)
+        val locationMode = preferences.get(PreferenceKey.LOCATION_MODE, LocationHandler.MANUAL_PROVIDER)
+        Log.v(Main.LOG_TAG, "WidgetUpdateWorker.doWork() location mode: $locationMode")


This uses android.preference.PreferenceManager, while the rest of the app (e.g., AppModule/Main) uses androidx.preference.PreferenceManager. Prefer androidx.preference.PreferenceManager.getDefaultSharedPreferences(...) here to avoid deprecated APIs and keep preference access consistent.

Copilot · 2026-04-18T16:48:50Z

+                        val x = calculateLocalCoordinate(location.longitude, scale)
+                        val y = calculateLocalCoordinate(location.latitude, scale)
+                        val dataArea = DataArea(x, y, scale)
+
+                        val parameters = Parameters(
+                            region = 0,
+                            gridSize = 5000,
+                            interval = TimeInterval(duration = 60),
+                            dataArea = dataArea
+                        )


Parameters is constructed with dataArea (local x/y/scale) but region = 0 (global). In JsonRpcData, GLOBAL_REGION ignores dataArea and calls the global endpoint, so the widget will not request local strike data around the location. Use region = LOCAL_REGION (from org.blitzortung.android.data.provider) when providing a DataArea, or route through the existing LocalData.updateParameters(...) logic to build consistent parameters.

Copilot · 2026-04-18T16:48:50Z

+        } catch (e: Exception) {
+            Log.e(Main.LOG_TAG, "WidgetUpdateWorker.doWork() failed", e)
+            return if (anyWidgetUpdated) {
+                Result.success()
+            } else {
+                // Retry for transient failures like network errors
+                Result.retry()
+            }
+        }


If doWork() throws before reaching the per-widget RemoteViews update (e.g., network error), the widget may be left showing the progress indicator set by WidgetClickReceiver, and you return Result.retry() without clearing it. Consider updating the widget in the exception path to hide the progress bar and show an error/last-updated timestamp, then decide whether to retry() or success() (to avoid an infinite progress state).

sonarqubecloud · 2026-04-18T18:17:49Z

Quality Gate failed

Failed conditions
1 Security Hotspot
35.6% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

wuan force-pushed the add_widget branch from a5f9ab6 to d773a6b Compare June 6, 2020 09:58

wuan force-pushed the add_widget branch 2 times, most recently from 296a553 to c92ef18 Compare June 20, 2020 07:32

wuan marked this pull request as draft March 21, 2021 11:13

wuan force-pushed the add_widget branch from c92ef18 to 906659f Compare March 21, 2021 11:20

wuan force-pushed the master branch 2 times, most recently from 55202a8 to 5417516 Compare July 15, 2022 23:02

wuan force-pushed the main branch from c25e5c4 to bbf9ab7 Compare July 11, 2024 15:44

perform simple widget rendering

5f65828

# Conflicts: # app/src/main/java/org/blitzortung/android/alert/handler/AlertHandler.kt # app/src/main/java/org/blitzortung/android/app/WidgetProvider.kt

wuan force-pushed the add_widget branch from 906659f to 5f65828 Compare October 13, 2024 21:02

wuan added 4 commits October 13, 2024 23:30

wip

46363ab

Merge remote-tracking branch 'origin/main' into add_widget

208105e

Merge remote-tracking branch 'origin/main' into add_widget

f421ab2

small updates

c53c162

wuan added 15 commits November 30, 2025 01:35

update widget every 5 minutes

84e1171

improve widget view integration

8e2954c

update

9ee2fe0

Merge remote-tracking branch 'origin/main' into add_widget

76e5395

update

c40275d

working widget

6a44540

working widget

afa6b8c

update

0840c93

mostly working

53c7a60

update

3552f24

try to fix the empty widget after loading

c864708

mostly there

bfd1661

add preview

88dae9e

update

62ded9a

update

e30defc

Copilot AI reviewed Apr 18, 2026

View reviewed changes

wuan added 3 commits April 18, 2026 09:03

widget update on tap and progress indicator

8f44578

fix location handler integration

8b2bf39

review fixes

b5e8549

wuan requested a review from Copilot April 18, 2026 07:29

Copilot started reviewing on behalf of wuan April 18, 2026 07:30 View session

Copilot AI reviewed Apr 18, 2026

View reviewed changes

wuan added 10 commits April 18, 2026 10:55

review fixes

e2db13e

add tests and disable detekt

402f65f

add a location info overlay to the widget

ebe492c

fix formatting

ae5f19b

revert to AGP 8

0584a12

revert to AGP 8

f7b0ee1

fix formatting

0e35db8

enable detekt

3ede6e8

fix detekt

e52ee82

add missing files

d7a2d2e

wuan added 2 commits April 18, 2026 17:52

extend memory

942a5c5

cap bitmap allocation

0cb70ab

wuan requested a review from Copilot April 18, 2026 16:38

Copilot started reviewing on behalf of wuan April 18, 2026 16:39 View session

Copilot AI reviewed Apr 18, 2026

View reviewed changes

wuan added 4 commits April 18, 2026 18:51

add tests

02cf0dd

add tests

99c7d1a

remove location overlay

15348d4

fix data time interval

32946b8

wuan merged commit 3c7ba50 into main Apr 18, 2026
5 checks passed

wuan deleted the add_widget branch April 18, 2026 18:10

		@@ -45,4 +45,41 @@ class AlertResultTest {
		assertThat(uut.bearingName).isEqualTo("foo")
		assertThat(uut.sectorWithClosestStrike).isNotNull

		val isPublic = java.lang.reflect.Modifier.isPublic(modifiers)
		assertThat(isPublic).isTrue()

	- Turbine 1.2.0 - Flow testing made easy
	- Turbine - Flow testing made easy

Uh oh!

Conversation

wuan commented Jun 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented Nov 30, 2025

Quality Gate failed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Apr 18, 2026

Quality Gate failed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Apr 18, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wuan commented Jun 5, 2020 •

edited

Loading