Add build target for x86#9
Merged
Merged
Conversation
Needed for old API (< 30) to avoid 16KB page_size issue with old libaries.
There was a problem hiding this comment.
Pull request overview
This PR updates the Android release build scripts to explicitly control React Native ABI targets, adding a dedicated x86/x86_64 release build path intended for older/emulator environments while keeping the default release build on ARM ABIs.
Changes:
- Constrain the default Android release build to ARM ABIs via
-PreactNativeArchitectures=armeabi-v7a,arm64-v8a. - Add a new
release:android:x86script to build x86/x86_64 release APKs. - Update
android/gradle.propertiescomments to document the intended ABI override behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Adds an x86/x86_64 Android release build script and pins the default release script to ARM ABIs. |
| android/gradle.properties | Updates inline documentation around reactNativeArchitectures defaults and CLI overrides. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for old API (< 30) to avoid 16KB page_size issue with old libraries.