Repository navigation
fix(cli): rethrow non-parse errors from brand-kits --social-links - #240
Merged
Merged
Conversation
The JSON.parse catch swallowed every error; baseline's no-swallowed-errors rule (run by check:all, not CI) flagged it. Only a SyntaxError is the user's input to fix, so anything else is rethrown. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GxJAQPBjUYxPXBeApMVLb8
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try { parsed = JSON.parse(raw); - } catch { + } catch (error) { + if (!(error instanceof SyntaxError)) { + throw error; + } return { ok: false, error: invalidValue(...) };Follow-up to #237.
pnpm baseline(part ofcheck:all, not CI) flagged the barecatchinpackages/cli/src/commands/brand-kits/brand-kits.tsunderno-swallowed-errors. It blocks the CLI release pre-flight.Evidence
pnpm baseline→1 error … no-swallowed-errors brand-kits.ts:358After:
✓ No violations found (2475 files scanned, 51 rules loaded)vitest run src/commands/brand-kits: 23 passed.tsc --noEmit(cli): 0.Merge Danger
Door: two-way
Blast Radius: none. Invalid JSON still gets the same
INVALID_FLAG_VALUEerror. Only an unexpected non-parse error now surfaces instead of being reported as bad JSON.🤖 Generated with Claude Code
https://claude.ai/code/session_01GxJAQPBjUYxPXBeApMVLb8