Repository navigation
fix: keep suppressed addresses out of broadcasts and out of bounce counts - #239
Merged
Merged
Conversation
…unts A manual suppression wrote only to the SES account suppression list, but broadcasts pick recipients from contact.email_status. The next broadcast still sent to those addresses, SES refused them with a Permanent bounce of subtype OnAccountSuppressionList, and the webhook recorded each one as a hard bounce. - Suppressing an address in the dashboard now marks the org's sendable contact suppressed (also when SES already had it); removing it returns a suppressed contact to active. - OnAccountSuppressionList and OnTenantSuppressionList bounces are suppressions, via one shared isSuppressionBounceSubType predicate used by the webhook, the SDK diagnostic path and the contact lifecycle. The bounce-reason metrics exclude them too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GxJAQPQtEUd9AV6C37CnJM
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A manual suppression only reached the SES list. Broadcasts read
contact.email_status, so the Oct 30 broadcast still sent to 5 suppressed addresses. SES refused them asPermanent / OnAccountSuppressionList, and the webhook counted each one as a hard bounce (bounced=6, suppressed=0; really 1 and 5).The bounce-reason metrics in
packages/dbexclude the same subtypes. That package can't import core, so it keeps a copy of the list, with a comment saying to change both together. The event-processor Lambda already treatedOnAccountSuppressionListas a suppression.Evidence
OnAccountSuppressionListbounce →status: "bounced",batch.bounced + 1, contactbounced). Suppression actions: 10 failed (the contact staysactiveafter Suppress).After: all green: API 2360, web 3812, db 342, core 240. Typecheck is clean.
e158d3d0was corrected by hand tobounced=1, suppressed=5, with the 5 contacts set tosuppressed.Merge Danger
Door: two-way
Code only, no migration. Reverting restores the old labelling.
Blast Radius: small
message_send.status = 'bounced'(unchanged). Only its contact and diagnostics change.🤖 Generated with Claude Code
https://claude.ai/code/session_01GxJAQPQtEUd9AV6C37CnJM