Repository navigation
fix: stop role_unreachable emails to customers who disconnected on purpose - #220
Merged
Merged
Conversation
…rpose `wraps platform disconnect` tore down the AWS side (event target, console role) but never told the platform, so aws_account kept its webhook_secret. account-health sweeps every account holding one; with the role deleted it reported "Wraps can no longer reach your AWS account" and, now that notify delivers by email, mailed the owner about it. - cli: `platform disconnect` calls DELETE /v1/connections/:id on the SaaS plane (not resolveApiTarget, which can follow a self-hosted activeInstance) after the target is removed and before the role is deleted. Failure is reported loudly, keeps the connection id, and a re-run finishes the server-side half. JSON output gains platformRecordCleared. - api: aws.role_unreachable notifies once per unreachable episode (since roleLastReachableAt) instead of daily, as a backstop for customers who disconnected with an older CLI. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GxJAQQq5ohyt3UR4EEgCx2
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
The baseline architecture rule flags any saveConnectionMetadata that comes before a deployment in source order. The re-run branch of `platform disconnect` saves metadata but never deploys, so annotate it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GxJAQQq5ohyt3UR4EEgCx2
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wraps platform disconnectnever told the platform, so the dashboard keptwebhook_secretandaccount-healthkept sweeping a role the customer deleted on purpose.getApiBaseUrl()+ the SaaS-slot token, notresolveApiTarget(): that followsactiveInstanceand could null the secret on the customer's own self-hosted plane.platformRecordCleared: falsein JSON, and keepsplatform.connectionId; re-running finishes the server half.Evidence
aws.role_unreachabledaily; first email went out 2026-10-28 once notify started delivering by email.After: 9 new tests (8 CLI, 1 worker), red before, green after;
src/commands814/814 andaccount-health*46/46 pass,tscclean.TorBox's
webhook_secretwas already cleared by hand in production.Merge Danger
Door: two-way. Revert restores the old behaviour; no schema change.
Blast Radius: narrow.
platform disconnectandaws.role_unreachableonly.fincancegorge,MealPlanAI) still hold a secret with an unreachable role; deliberately left alone.🤖 Generated with Claude Code
https://claude.ai/code/session_01GxJAQQq5ohyt3UR4EEgCx2