Repository navigation
fix(web): dashboard favicon follows light/dark theme - #218
Merged
Merged
Conversation
…heme Next's app/favicon.ico file convention emitted an unconditional <link rel="icon" href="/favicon.ico"> ahead of the prefers-color-scheme icons in layout.tsx, so dark-mode browsers showed a black W on black. Removing it leaves only the media-conditioned favicon-light/dark links. public/favicon.ico stays as the fallback for direct /favicon.ico requests. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GxJAQPrkVPBHgARDeX6HPX
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In dark-mode browsers the dashboard tab icon is a black W on a dark tab bar, so it's invisible.
Cause
apps/web/src/app/favicon.ico(black W) triggers Next's file convention, which emits an unconditional<link rel="icon" href="/favicon.ico">ahead of theprefers-color-schemeicons declared inlayout.tsx. Browsers pick the unconditional one. Confirmed on production:app.wraps.dev/sign-inserves the.icolink first;wraps.devhas no such file and is already correct.Fix
Delete
apps/web/src/app/favicon.ico. The head now only containsfavicon-light.png/favicon-dark.pngwith media queries.public/favicon.icois kept as the fallback for direct/favicon.icorequests.Verify
After deploy,
curl -sL https://app.wraps.dev/sign-in | grep -o '<link[^>]*rel="icon"[^>]*>'should no longer show/favicon.ico?favicon…. Not run locally. Safari ignoresmediaon icon links, so it won't follow the theme.🤖 Generated with Claude Code
https://claude.ai/code/session_01GxJAQPrkVPBHgARDeX6HPX