Repository navigation
fix(web): flush Radix FocusScope timer before jsdom teardown in contacts table test - #196
Merged
Merged
Conversation
…cts table test Radix FocusScope dispatches its unmount event from a setTimeout(0). When that fired after vitest tore down jsdom, the cross-realm CustomEvent was rejected by dispatchEvent and surfaced as an unhandled error, failing test-web on main even though all tests passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pzn7odPuYSivoc4b2XyQ7q
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
test-webfailed on main at 15b8000 even though all 3,351 tests passed. Vitest caught one unhandled error fromcontacts-table-analytics.test.tsx:Why
Radix FocusScope dispatches its unmount event from a
setTimeout(0). The test'safterEach(cleanup)unmounts but doesn't wait for that timer. When the timer fires after vitest tears down jsdom, the event belongs to a dead realm anddispatchEventrejects it.Fix
After
cleanup(),afterEachwaits one macrotask so the timer fires while jsdom is still alive.Verified locally: the file passes 3/3 runs.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Pzn7odPuYSivoc4b2XyQ7q