Repository navigation
Fix live search tests to treat result count as a limit - #1214
Merged
Merged
Conversation
8 of 9 tasks
ebhills
marked this pull request as ready for review
September 30, 2026 19:10
16 of 40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #1213. Follow-up to the unrelated search-test failure after #1212.
What changes
The live search test requested seven results and received six, causing an incorrect exact-count failure. Live assertions now accept successful, nonempty results up to the requested limit and still reject provider errors. The multiple-query test checks every query response.
Adds offline cases for provider counts of 0, 6, 7, and 9 with a limit of 7, verifying returned counts of 0, 6, 7, and 7, result ordering, row identity, and the outgoing limit. Runtime behavior is unchanged.
How it was verified
scripts/test-local.ps1): 2,680 passed, 6 skipped, 139 deselected.TestFindLinksmethods against a synthetic six-result provider with network access blocked; all passed. This isolated check loaded only the search test class, excluding live retrieval setup.git diff --checkpassed. Two-file scope reviewed; branch current with freshly fetchedorigin/main.test_search_with_n_results, six results versus an exact expectation of seven.Compatibility and risk
Test-only change in two existing files; no public API, runtime, schema, configuration, credential, or deployment changes. The live tests continue requiring successful, nonempty responses for their normal queries. Offline tests cover a valid empty provider response independently. Revert this commit to roll back.
Ready-for-review checklist
mainand has no merge conflictsSee the pull request workflow.