verification of content-type and status code for http file server exercise#398
verification of content-type and status code for http file server exercise#398jpdamon wants to merge 1 commit intoworkshopper:masterfrom
Conversation
|
Continuing conversation here: Yes, the tests obviously didn't cover this particular use-case before so it would be good to have a test-case covering this particular problem. The test cases are quite simple: Just add a Also it would be good if the PR would contain the locales in all languages - even if they are in english - since there is no fallback yet. |
|
Makes sense, will do. The issue I'm having though is that |
|
😱 I only read the first part of your last comment. |
|
This PR seems to be okay to be merged. Although its 2 years old, we could have somebody take a look at this. |
Clarified that setting the content-type and status code are now required. Added verification to exercise.js
Fixes #348