Skip to content

[DE-4902] fixing javascript overflow with int, snowflake connector with key file/pwd auth method#9

Merged
gregosaurus merged 2 commits into
upstream-masterfrom
de-4902-add-snowflake-support
Jun 19, 2025
Merged

[DE-4902] fixing javascript overflow with int, snowflake connector with key file/pwd auth method#9
gregosaurus merged 2 commits into
upstream-masterfrom
de-4902-add-snowflake-support

Conversation

@gregosaurus

@gregosaurus gregosaurus commented Jun 17, 2025

Copy link
Copy Markdown

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

This PR update redash based on the latest release, fix the JavaScript Number overflowing issue and add support for keypair authentication for the Snowflake driver.

Comment thread poetry.lock
@@ -946,16 +1108,17 @@ files = [
tomli = {version = "*", optional = true, markers = "python_full_version <= \"3.11.0a6\" and extra == \"toml\""}

[package.extras]
toml = ["tomli"]
toml = ["tomli ; python_full_version <= \"3.11.0a6\""]

[[package]]
name = "crontab"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License Risk: crontab@1.0.4 uses GPL-2.0-only

GPL-2.0-only violates license policy.

Severity: Medium ⚠️
Status: Open 🔴

License Details:

  1. GPL-2.0-only

Suggested reviewers 🧐: @gregosaurus

Details

Take action by replying with an [arnica] command 💬

Actions

Use [arnica] or [a] to interact with the Arnica bot to acknowledge or dismiss code risks.

To acknowledge the finding as a valid code risk:

[arnica] ack <acknowledge additional details>

To dismiss the risk with a reason:

[arnica] dismiss <fp|accept|capacity> <dismissal reason>

Examples

  • [arnica] ack This is a valid risk and im looking into it

  • [arnica] dismiss fp Dismissed - Risk Not Accurate: (i.e. False Positive)

  • [arnica] dismiss accept Dismiss - Risk Accepted: Allow the risk to exist in the system

  • [arnica] dismiss capacity Dismiss - No Capacity: This will need to wait for a future sprint

More details:

🌻 View in Arnica

For license findings, please review our legal policy: https://wiki.playtika.com/pages/viewpage.action?spaceKey=LEG&title=Open+Source+Code+Usage+Guidelines

Comment thread poetry.lock
@@ -574,13 +725,14 @@ graph = ["gremlinpython (==3.3.4)"]

[[package]]
name = "certifi"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License Risk: certifi@2025.6.15 uses MPL-2.0

MPL-2.0 violates license policy.

Severity: Medium ⚠️
Status: Open 🔴

License Details:

  1. MPL-2.0

Suggested reviewers 🧐: @gregosaurus

Details

Take action by replying with an [arnica] command 💬

Actions

Use [arnica] or [a] to interact with the Arnica bot to acknowledge or dismiss code risks.

To acknowledge the finding as a valid code risk:

[arnica] ack <acknowledge additional details>

To dismiss the risk with a reason:

[arnica] dismiss <fp|accept|capacity> <dismissal reason>

Examples

  • [arnica] ack This is a valid risk and im looking into it

  • [arnica] dismiss fp Dismissed - Risk Not Accurate: (i.e. False Positive)

  • [arnica] dismiss accept Dismiss - Risk Accepted: Allow the risk to exist in the system

  • [arnica] dismiss capacity Dismiss - No Capacity: This will need to wait for a future sprint

More details:

🌻 View in Arnica

For license findings, please review our legal policy: https://wiki.playtika.com/pages/viewpage.action?spaceKey=LEG&title=Open+Source+Code+Usage+Guidelines

Comment thread poetry.lock
ocsp = ["certifi", "cryptography (>=2.5)", "pyopenssl (>=17.2.0)", "requests (<3.0.0)", "service-identity (>=18.1.0)"]
encryption = ["certifi ; os_name == \"nt\" or sys_platform == \"darwin\"", "pymongo[aws]", "pymongocrypt (>=1.6.0,<2.0.0)"]
gssapi = ["pykerberos ; os_name != \"nt\"", "winkerberos (>=0.5.0) ; os_name == \"nt\""]
ocsp = ["certifi ; os_name == \"nt\" or sys_platform == \"darwin\"", "cryptography (>=2.5)", "pyopenssl (>=17.2.0)", "requests (<3.0.0)", "service-identity (>=18.1.0)"]
snappy = ["python-snappy"]
test = ["pytest (>=7)"]
zstd = ["zstandard"]

[[package]]
name = "pymssql"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License Risk: pymssql@2.3.4 uses LGPL-3.0-or-later

LGPL-3.0-or-later violates license policy.

Severity: Medium ⚠️
Status: Open 🔴

License Details:

  1. LGPL-3.0-or-later

Suggested reviewers 🧐: @gregosaurus

Details

Take action by replying with an [arnica] command 💬

Actions

Use [arnica] or [a] to interact with the Arnica bot to acknowledge or dismiss code risks.

To acknowledge the finding as a valid code risk:

[arnica] ack <acknowledge additional details>

To dismiss the risk with a reason:

[arnica] dismiss <fp|accept|capacity> <dismissal reason>

Examples

  • [arnica] ack This is a valid risk and im looking into it

  • [arnica] dismiss fp Dismissed - Risk Not Accurate: (i.e. False Positive)

  • [arnica] dismiss accept Dismiss - Risk Accepted: Allow the risk to exist in the system

  • [arnica] dismiss capacity Dismiss - No Capacity: This will need to wait for a future sprint

More details:

🌻 View in Arnica

For license findings, please review our legal policy: https://wiki.playtika.com/pages/viewpage.action?spaceKey=LEG&title=Open+Source+Code+Usage+Guidelines

@gregosaurus gregosaurus changed the title [WIP][DE-4902]: fixing javascript overflow with int, snowflake connector with key file/pwd auth method [DE-4902]: fixing javascript overflow with int, snowflake connector with key file/pwd auth method Jun 18, 2025
@gregosaurus gregosaurus requested a review from a team June 18, 2025 13:52
@gregosaurus gregosaurus changed the title [DE-4902]: fixing javascript overflow with int, snowflake connector with key file/pwd auth method [DE-4902] fixing javascript overflow with int, snowflake connector with key file/pwd auth method Jun 18, 2025
@gregosaurus gregosaurus merged commit ce2e26f into upstream-master Jun 19, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants