ML-DSA: Add optional context to signing and verification#90
Open
mjdemilliano wants to merge 3 commits intowolfSSL:masterfrom
Open
ML-DSA: Add optional context to signing and verification#90mjdemilliano wants to merge 3 commits intowolfSSL:masterfrom
mjdemilliano wants to merge 3 commits intowolfSSL:masterfrom
Conversation
Member
|
@mjdemilliano is an approved contributor |
There was a problem hiding this comment.
Pull request overview
This PR adds optional “context” (ctx) support to ML-DSA (Dilithium) signing and verification, enabling domain separation when using the wolfSSL context-aware APIs.
Changes:
- Extend
MlDsaPrivate.sign()and_MlDsaBase.verify()with an optionalctxargument and route to*_ctx_msgwolfCrypt APIs when provided. - Add tests covering sign/verify behavior with correct/incorrect context.
- Extend the CFFI bindings to include
wc_dilithium_sign_ctx_msgandwc_dilithium_verify_ctx_msg.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
wolfcrypt/ciphers.py |
Adds ctx parameter and switches between ctx/non-ctx wolfCrypt functions. |
tests/test_mldsa.py |
Adds coverage for context-aware signing and verification. |
scripts/build_ffi.py |
Declares the new ctx-aware wolfCrypt APIs in the FFI cdef. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danielinux
previously requested changes
Apr 8, 2026
Member
danielinux
left a comment
There was a problem hiding this comment.
Please address copilot's commends
Contributor
Author
|
Addressed Copilot comments. |
dgarske
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.