Skip to content

Create small default segment if out of heap #5736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DedeHai wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Create small default segment if out of heap #5736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions wled00/FX_fcn.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1968,8 +1968,9 @@ void WS2812FX::resetSegments() {
if (isServicing()) return;
_segments.clear(); // destructs all Segment as part of clearing
_segments.emplace_back(0, isMatrix ? Segment::maxWidth : _length, 0, isMatrix ? Segment::maxHeight : 1);
if(_segments.size() == 0) {
_segments.emplace_back(); // if out of heap, create a default segment
if (getActiveSegmentsNum() == 0) {
_segments.clear(); // free failed segment
_segments.emplace_back(); // if out of heap, create a default 30 pixel segment
errorFlag = ERR_NORAM_PX;
}
_segments.shrink_to_fit(); // just in case ...
Expand Down Expand Up @@ -2046,6 +2047,7 @@ void WS2812FX::makeAutoSegments(bool forceReset) {
#endif
}
}
if (getActiveSegmentsNum() == 0) resetSegments(); // fallback if auto segment creation failed
_mainSegment = 0;

fixInvalidSegments();
Expand Down
Loading