Repository navigation
Fix CRT startup and media DLL checks in automatic builds - #525
Merged
Merged
Conversation
intraducine
changed the title
125hz
added a commit
that referenced
this pull request
Nov 2, 2026
Their changes are already on main as squashed commits, each authored by its author (insertfloppy), on top of #525. They merged without conflicts; the host checks they touch (translations, GPU card, recommended lists, D3D9 older NVIDIA, KMT adapter, library sections, frontend, settings catalog, JIT method, runtime settings, Dock start screen) pass on the combined tree. This merge only adds the pull requests' heads as parents (the ours strategy changes no files), so GitHub shows them as merged. Pull requests: #528 #530 #531 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic builds changed Wine's CRT delay imports into immediate imports. The reported device log reaches JIT successfully, then crashes at
ucrtbase.dll+0x63670while loadingxtajit64.dll. An existing eager-link build has the same six instruction words at that offset.PR #496 identified the startup dependency cycle and has now merged. This follow-up applies the fix in the shared module builder, including DLLs added by
targets.pyduring import closure:msvcrtand modules built from its sources. Relink these modules so an earlier eager-link output cannot survive an incremental build.d2d1.advapi32oruser32imports in packageducrtbase.dllandmsvcrt.dll, including cache restores and final IPA checks.The post-merge main build also fails the media check:
wmvcore reader must import its real winegstreamer frontend. The blanketUNDELAY=0change leaves that dependency delayed. Keeping the non-CRT workaround also fixes this build failure.Validation: all 14 runtime tests pass, including the production build script with old CRT outputs, temporary-source restoration on failure, and invalid cached/packaged DLLs with valid checksums. Build-input and component-cache checks pass. The new binary check rejects both historical eager-link CRTs and accepts the tracked CRTs.
Six extra build-script checks pass for mixed and CRT-only module sets with
UNDELAYunset,0, and1. Three code review passes covered DLL load order, build callers and source restoration, and cache and package checks.The full automatic build passed at
7ab9c29415c00582220fe8b3aed76199f545bc7d. All component jobs passed. The app job validated the complete IPA and uploaded theMadeira-ipaartifact.Thanks to g6c8jfntbc-dotcom for the diagnosis in #496. A fresh physical-device launch and gameplay test remain untested.