fix(chains): preserve OP predeploy contracts on Zircuit#4526
Merged
Conversation
|
@mk0walsk is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: c01c587 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
863dd90 to
0778bba
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a silent config-loss bug in Zircuit OP Stack chain definitions.
What is this PR solving?
zircuitandzircuitGarfieldTestnetspread...chainConfigat the top level, but theircontractsobjects did not spread...chainConfig.contracts, which overwrote OP predeploy defaults (for examplegasPriceOracle,l1Block, andl2ToL1MessagePasser).This change adds
...chainConfig.contractsin:src/chains/definitions/zircuit.tssrc/chains/definitions/zircuitGarfieldTestnet.tsRelated: #4423
What alternatives were explored?
contractsinsidedefineChainwas considered, but it would change merge semantics globally.src/op-stack/contracts.tswas unnecessary because defaults there are already correct.What should reviewers pay extra attention to?
Documentation
No documentation update is needed because this is an internal chain-definition correctness fix with no public API change.
Tests
Please run:
pnpm test:chainspnpm check:types