Skip to content

Phase 5: split oversized SwiftUI views#351

Merged
weiran merged 1 commit intomasterfrom
codex/phase-5-ui-file-splits
May 4, 2026
Merged

Phase 5: split oversized SwiftUI views#351
weiran merged 1 commit intomasterfrom
codex/phase-5-ui-file-splits

Conversation

@weiran
Copy link
Copy Markdown
Owner

@weiran weiran commented May 4, 2026

Summary

  • Split the embedded browser comments sheet and controls out of the oversized browser source file
  • Move comments toolbar/helper components into their own Comments source file
  • Trim FeedView below the configured file-length threshold without changing behavior

Validation

  • xcodebuild build -project Hackers.xcodeproj -scheme Hackers -destination 'platform=iOS Simulator,name=iPhone 17 Pro'
  • swiftlint lint --config .swiftlint.yml --quiet
  • ./run_tests.sh
  • ./run_tests.sh Feed Comments

Summary by CodeRabbit

Release Notes

  • New Features
    • Added a collapsible comments sheet that displays post discussions with drag-to-expand functionality
    • Added in-app browser navigation controls (back, forward, reload) and share options
    • Enhanced comments toolbar with bookmark toggle and share menu capabilities

@coderabbitai

This comment has been minimized.

coderabbitai[bot]

This comment was marked as resolved.

@weiran weiran merged commit 10250fc into master May 4, 2026
4 checks passed
@weiran weiran deleted the codex/phase-5-ui-file-splits branch May 4, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant