Fix bootstrap problem with logger function. - #657
Merged
Conversation
To intercept this with a log handler, it must be possible to set the log handler before any logging takes place. This logger_func / logger_user_data cannot be part of webui_core_t, because logging is already used in _webui_init() and _webui of type webui_core_t gets reset to 0 in _webui_init(). Signed-off-by: Hans Dijkema <hans@dijkewijk.nl>
Contributor
Author
|
Also va_end needs to complement va_start (otherwise this could result in a memory leak or other problems). |
AlbertShown
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bootstrap problem with logger function.
To intercept this with a log handler, it must be possible to set
the log handler before any logging takes place.
This logger_func / logger_user_data cannot be part of webui_core_t,
because logging is already used in _webui_init() and _webui of
type webui_core_t gets reset to 0 in _webui_init().