Skip to content

Fix endless recursion on webui_malloc in debug mode. #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlbertShown merged 4 commits into from
Oct 21, 2025
Merged

Fix endless recursion on webui_malloc in debug mode. #655

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dae93fe
Fix endless recursion on webui_malloc in debug mode.
hdijkema Oct 21, 2025
dc8589c
Merge branch 'main' into recursion-fix
AlbertShown Oct 21, 2025
f517134
Fix typo (because of a merging conflict)
AlbertShown Oct 21, 2025
5921999
Fix typo (because of a merging conflict)
AlbertShown Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/webui.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,14 +727,16 @@ static void _webui_log(size_t level, const char *format, va_list args) {
_webui.logger_func(WEBUI_LOGGER_LEVEL_ERROR, "Log formatting error", _webui.logger_user_data);
return;
}
char *buffer = _webui_malloc(needed_size + 1);

char buf[256];
char *buffer = (needed_size > 255) ? _webui_malloc(needed_size + 1) : buf;
if (buffer == NULL) {
_webui.logger_func(WEBUI_LOGGER_LEVEL_ERROR, "Memory allocation failed for log", _webui.logger_user_data);
return;
}
vsnprintf(buffer, needed_size + 1, format, args);
_webui.logger_func(level, buffer, _webui.logger_user_data);
_webui_free_mem((void*)buffer);
if (buffer != buf) _webui_free_mem((void*)buffer);
}
}

Expand Down
Loading