Introduce "too late" presence option to event attendees#4528
Merged
Conversation
ivarnakken
added
review-needed
norbye
approved these changes
Mar 7, 2024
norbye
left a comment
norbye
left a comment
Member
There was a problem hiding this comment.
Awesome, love the look!
While the padding may feel like much - I currently like how it is evenly spaced vertically and horizontally. And anyways lets get it out there to get a feel of it
eikhr
approved these changes
Mar 8, 2024
eikhr
left a comment
eikhr
left a comment
Member
There was a problem hiding this comment.
Awesome!
As for the design, it might also work well with a dropdown like in the bdb
Member
Author
I contemplated it. Even though it would save us space, it would require the user to click two times, instead of just one, so I ended up not doing it. |
ivarnakken
added
approved
ivarnakken
force-pushed
the
ivarnakken/aba-868-too-late
branch
from
b999072 to
46f30ef
Compare
Neither ion-icons or font-awesome had a turtle icon, so I extracted one from Lucide (which we're planning on migrating to). I'm very open to design suggestions, as I'm not sure what I feel about this. The padding feels a bit much, so I might refactor the Icon component - but that will probably have to wait.
ivarnakken
force-pushed
the
ivarnakken/aba-868-too-late
branch
from
46f30ef to
a4ddb84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related backend changes
Neither ion-icons or font-awesome had a turtle icon (which I thought was the most fitting), so I extracted one from Lucide (which we're planning on migrating to). I'm very open to design suggestions, as I'm not sure what I feel about this. The padding feels a bit much, so I might refactor the Icon component - but that will probably have to wait.
Result
If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.
The automatic penalty:
Testing
Things work. Tested that all other icons that use the
TooltipIconcomponent still work and look good.