[WIP] fix(ffmpeg): Handle compressed assets and tag arm architecture in releases.js#1068
Draft
detox-24 wants to merge 1 commit intowebinstall:mainfrom
Draft
[WIP] fix(ffmpeg): Handle compressed assets and tag arm architecture in releases.js#1068detox-24 wants to merge 1 commit intowebinstall:mainfrom
detox-24 wants to merge 1 commit intowebinstall:mainfrom
Conversation
Member
Author
|
Oh I have just noted! AJ wanted compressed releases to be made, he even made an issue in the official static releases repo! The direction from now would be to handle the compressed asset in install.sh/ps1. Converting this to draft for now. |
detox-24
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static releases we use for ffmpeg have only two release assets,
Filtered the .gz assets to prevent webi from selecting and trying to extract a compressed binary.
Tagged arm variant releases explicitly, ensuring the right selection of asset.
Fixes #947.