fix(bun): prefer baseline linux releases (fix #879)#1048
fix(bun): prefer baseline linux releases (fix #879)#1048coolaj86 merged 3 commits intowebinstall:mainfrom
Conversation
|
Weird, I thought I had fixed this years ago. Looks good. Testing now. note: GitHub Releases seems to be having an outage (release downloads aren't working on my server or my home laptop), making it difficult to get a new testing environment up. I'll try again tomorrow. |
There was a problem hiding this comment.
Pull request overview
Updates Bun’s release normalization so Linux -baseline assets are retained and preferred over the default Linux x64 assets to avoid SIGILL on older/container CPUs.
Changes:
- Stop filtering out Bun Linux
-baselineassets; continue filtering out-profilebuilds. - Prefer
-baselineover default for the same Linux x64 target (including-musl) via release ordering. - Add a narrow regression test for Linux baseline preference and non-Linux ordering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| bun/releases.js | Refactors release filtering/normalization and adds baseline-preferred ordering logic for Linux x64 targets. |
| bun/releases.test.js | Adds a node:test regression test for baseline ordering and non-Linux order preservation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
649e0ef to
f06943d
Compare
f06943d to
d739ca8
Compare
coolaj86
left a comment
There was a problem hiding this comment.
The sort strategy alone didn't work, but I changed it to just use baseline when baseline is available and that solves the problem.
|
@detox-24 This was also kinda Ai slop (it didn't actually understand the problem to fix it correctly). However, it was at least attempting to address an actual problem. |
|
Ah! I gotta keep a sharper eye! |
Fixes #879
Summary
-baselineLinux assets instead of filtering them outWhy
buncan select a non-baseline Linux binary that crashes withSIGILLon older/container CPUs.This change makes the release list prefer the baseline variant when both assets exist for the same target.
Testing
bun/releases.test.jscovering:Notes
I could not run the repo's Node-based lint/test commands locally in this environment because
node/npmwere unavailable.