chore(#50): submodule bump for Tier-3 pose-math removal + close-out doc - #47
Merged
Conversation
Companion to webarkit/WebARKitLib#58. Bump the submodule to the commit removing the superseded computePose/invertPose/computeGLviewMatrix()-noarg, and rebuild build/ + dist/ (emscripten output is not byte-reproducible). docs/audit-dead-code-issue50.md: move the computePose cluster from "pending" to "removed (#58)"; the #50 audit is now complete (everything else decided KEEP). Verified: static example tracks (pyrLevel 1, 1000 matches); live pose path unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Re-point the submodule at the canonical webarkit/WebARKitLib dev tip after #58 (Tier-3: remove superseded computePose/invertPose/computeGLviewMatrix()) merged. Completes the #50 dead-code cleanup. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kalwalt
added
enhancement
github-project-automation
Bot
moved this from Reviewer approved
to Done
in New markerless image tracking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to webarkit/WebARKitLib#58 (Tier-3: remove superseded
computePose/invertPose/computeGLviewMatrix()-noarg).What
docs/audit-dead-code-issue50.md: move thecomputePosecluster from "pending" to "removed (#58)" — the Integrate webarkit-testing dev → main #50 audit is now complete (every other flagged symbol was decided KEEP).No
build//dist/changeThe removed functions were already unreferenced and dead-code-eliminated by the linker, so the emscripten output is byte-identical to
dev— verifiedgit diff dev -- build/ dist/is empty. (Rebuilt and tested anyway: static example tracks, pyrLevel 1, 1000 matches; behavior-neutral, live pose path unchanged.)Status
After this merges, #50 can be closed.
🤖 Generated with Claude Code