Skip to content

HTML: make muted attribute no longer rely on non-existing element creation-time #59322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zcorpan merged 1 commit into from
May 5, 2026
+56 −10
Merged

HTML: make muted attribute no longer rely on non-existing element creation-time #59322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions css/selectors/media/sound-state.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,30 @@
assert_equals(document.querySelector("video:muted"), video);
assert_equals(document.querySelector("video:not(:muted)"), null);
}, "Test :muted pseudo-class");

test((t) => {
assert_implements(CSS.supports("selector(:muted)"), ":muted is not supported");

const video = document.createElement("video");
document.body.appendChild(video);
t.add_cleanup(() => video.remove());

assert_false(video.muted);
assert_false(video.matches(":muted"));

video.setAttribute("muted", "");
assert_true(video.muted);
assert_true(video.matches(":muted"));

video.removeAttribute("muted");
assert_false(video.muted);
assert_false(video.matches(":muted"));

video.setAttribute("muted", "");
assert_true(video.muted);
video.muted = false;
assert_false(video.muted);
assert_false(video.matches(":muted"));
}, "Test :muted matches .muted for content attribute default");
</script>
</body>
41 changes: 31 additions & 10 deletions html/semantics/embedded-content/media-elements/user-interface/muted.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
}
</script>

<!-- These tests are inside <audio>/<video> so that the steps for updating the
muted IDL attribute cannot be delayed until the end tag is parsed. -->
<!-- These tests are inside <audio>/<video> so that the parser-created
elements are available for testing before the closing tag. -->

<audio id=a1>
<script>
Expand Down Expand Up @@ -80,8 +80,8 @@
</script>
</video>

<!-- Negative test to ensure that the load algorithm does not update the
muted IDL attribute to match the content attribute. -->
<!-- Negative test to ensure that the load algorithm does not reset the
muted state. -->

<video id=v3 muted></video>
<script>
Expand Down Expand Up @@ -112,25 +112,22 @@
test(function() {
var m = document.createElement(tagName);
m.setAttribute('muted', '');
assert_false(m.muted);
assert_true(m.muted);
}, 'getting ' + tagName + '.muted with muted="" (script-created)');

test(function() {
var m = document.createElement(tagName);
m.setAttribute('muted', '');
test_setting(m, false, true);
test_setting(m, true, true);
}, 'setting ' + tagName + '.muted with muted="" (script-created)');

// Spec bug: https://www.w3.org/Bugs/Public/show_bug.cgi?id=25153
/*
test(function() {
var m = document.createElement(tagName);
m.setAttribute('muted', '');
m = m.cloneNode(false);
assert_true(m.hasAttribute('muted'));
assert_false(m.muted);
assert_true(m.muted);
}, 'getting ' + tagName + '.muted with muted="" (cloneNode-created)');
*/

test(function() {
var div = document.createElement('div');
Expand Down Expand Up @@ -165,5 +162,29 @@
var c = m.cloneNode(true);
assert_true(c.muted);
}, 'cloning ' + tagName + ' propagates muted (innerHTML-created)');

test(function() {
var m = document.createElement(tagName);
assert_false(m.muted);
m.setAttribute('muted', '');
assert_true(m.muted);
m.removeAttribute('muted');
assert_false(m.muted);
}, 'adding/removing muted attribute dynamically affects ' + tagName + '.muted');

test(function() {
var m = document.createElement(tagName);
m.muted = false;
m.setAttribute('muted', '');
assert_false(m.muted);
}, 'adding muted attribute has no effect on ' + tagName + '.muted after setter');

test(function() {
var m = document.createElement(tagName);
m.setAttribute('muted', '');
m.muted = true;
m.removeAttribute('muted');
assert_true(m.muted);
}, 'removing muted attribute has no effect on ' + tagName + '.muted after setter');
});
</script>
Loading