Skip to content

convert from fmpq_mat to Matrix{Rational} - #64

Open
cossio wants to merge 1 commit into
wbhart:masterfrom
cossio:patch-5
Open

convert from fmpq_mat to Matrix{Rational}#64
cossio wants to merge 1 commit into
wbhart:masterfrom
cossio:patch-5

Conversation

@cossio

@cossio cossio commented Sep 12, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@wbhart

wbhart commented Sep 12, 2016

Copy link
Copy Markdown
Owner

Thanks again! In both these pull requests, it makes sense to write a test which converts to a Julia matrix and then back again and checks if the result is the same.

You would add a new test function for this in Nemo/test/flint/fmpq_mat-tests.jl, etc.

This way, Travis-CI would be testing something nontrivial.

Also, you might want to add a section on conversions in doc/src/matrix.jl You'd need a docstring on the actual functions. (We can run the documentation parser once the docs exist.)

@cossio

cossio commented Sep 12, 2016

Copy link
Copy Markdown
Contributor Author

Thanks. I will take a look at the tests and the docs tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants