convert from fmpq_mat to Matrix{Rational} - #64
Open
cossio wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks again! In both these pull requests, it makes sense to write a test which converts to a Julia matrix and then back again and checks if the result is the same. You would add a new test function for this in Nemo/test/flint/fmpq_mat-tests.jl, etc. This way, Travis-CI would be testing something nontrivial. Also, you might want to add a section on conversions in doc/src/matrix.jl You'd need a docstring on the actual functions. (We can run the documentation parser once the docs exist.) |
Contributor
Author
|
Thanks. I will take a look at the tests and the docs tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.