Skip to content

wayland-hwc: Drop dummy window hack & QtMir integration improvements #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fredldotme wants to merge 8 commits into
base: lineage-17.1
Choose a base branch
from
Open

wayland-hwc: Drop dummy window hack & QtMir integration improvements #6

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b91bf2a
wayland-hwc: Drop dummy window hack & commit appID earlier
fredldotme Jun 18, 2022
d8c6048
wayland-hwc: Store and track windows through appID
fredldotme Jun 18, 2022
8eaef95
wayland-hwc: Remove appID commits and spawn EGL window
fredldotme Jun 18, 2022
1a035ff
hwcomposer: Use frame information to pass EGL window width/height
fredldotme Jun 18, 2022
41421bd
wayland-egl: Build in-tree
fredldotme Jun 18, 2022
69e392d
hwcomposer: Initialize cursor_surface to nullptr
fredldotme Jun 18, 2022
ef1cb3c
hwcomposer: Ignore non-active windows in multi-window mode too
fredldotme Jun 18, 2022
bedfe08
hwcomposer: Also free the window when not in use anymore
fredldotme Jun 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hwcomposer/hwcomposer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,6 +1006,9 @@ static int hwc_open(const struct hw_module_t* module, const char* name,
if (!property_get_bool("persist.waydroid.cursor_on_subsurface", false))
pdev->display->cursor_surface =
wl_compositor_create_surface(pdev->display->compositor);
else
pdev->display->cursor_surface = nullptr;

@dos1 dos1 Aug 30, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really well-versed in C++, but since the display is allocated with struct display *display = new struct display();, this should mean that all its members get value-initialized, which in case of pointers initializes them to nullptr already. Is that not the case here?


if (!pdev->display->height) {
pdev->display->waiting_for_data = true;
pthread_cond_timedwait(&pdev->display->data_available_cond,
Expand Down