add support for simulating wifi#8
Conversation
|
I think it's need an auto-adjusting mechanizm like detecting the cfg80211 and virt_wifi ko, if exists, set a property into waydroid_base.prop. |
|
This is not working for me: $ sudo waydroid shell -- ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet 127.0.0.1/8 scope host lo
valid_lft forever preferred_lft forever
inet6 ::1/128 scope host
valid_lft forever preferred_lft forever
2: wifi_eth@if29: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
link/ether 00:16:3e:f9:d3:03 brd ff:ff:ff:ff:ff:ff link-netnsid 0
inet6 fe80::216:3eff:fef9:d303/64 scope link
valid_lft forever preferred_lft forever
3: wlan0@wifi_eth: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000
link/ether 00:16:3e:f9:d3:03 brd ff:ff:ff:ff:ff:ff |
|
It lack of an automative action of connecting virtwifi. |
|
I'm not sure I understand. |
| if [ ! -d /sys/class/net/wlan0 ]; then | ||
| /system/bin/ifconfig eth0 down | ||
| /system/bin/ip link set eth0 name wifi_eth | ||
| /system/bin/ifconfig wifi_eth up | ||
| /system/bin/ip link add link wifi_eth name wlan0 type virt_wifi | ||
| fi |
There was a problem hiding this comment.
This needs rework.
- Do NOT rename
eth0like that, people will not be happy to have their main ethernet connection be renamed like that.- Not to mention that systems can have different names instead of
eth0.
Most distros have nowerdays changed to useeno1as default for example...
- Not to mention that systems can have different names instead of
- Not all systems have their wifi named
wlan0.
It's better to find an automated way of finding what name the wifi card(s) use.
Maybe something like:wificards=( $(iwconfig 2>/dev/null | grep 'IEEE 802.11' | cut -d ' ' -f 1) ) for wifi in "${wificards[@]}"; do ... done
Last but not least, i would prefer it much more to use netdev files to setup this virt_wifi link.
There was a problem hiding this comment.
Besides i don't really understand the need for all this renaming of links anyhow 🤷♀️
There was a problem hiding this comment.
If that part is to be moved to the host couldn't the virtual wlan setup be handled by the already existing https://github.com/waydroid/waydroid/blob/main/data/scripts/waydroid-net.sh? I'd prefer not adding dependencies on random systemd components for core fixes like "apps not detecting any networking" if that can be avoided
There was a problem hiding this comment.
Agree about the place to move that part.
But strongly disagree with the "random systemd components" with same arguments for usage of non-systemd solutions on a systemd based system which most distro's use these days...
- Pssttt they already make use of
systemdstuff, seewaydroid-container.service😉
If they want to be totally politically correct they should implement all this stuff they do now in scripts, inside a compiled C++ binary that directly calls kernel functions...
There was a problem hiding this comment.
The init script is different because that's just the entrypoint and easily replicatable anywhere, if other waydroid parts depend on systemd handling something it'll just be broken elsewhere silently
There was a problem hiding this comment.
@TriMoon This eth0 is inside of Waydroid's own network namespace (which is a veth pair connected to the waydroid0 bridge in the host), and it is not related to the host's network devices
There was a problem hiding this comment.
@supechicken do you have this working? Can you help me understand what I'm missing?
There was a problem hiding this comment.
@supechicken do you have this working? Can you help me understand what I'm missing?
I haven't started trying this yet 😅 (will leave a comment here when got progress)
|
Any progress ? |
|
@aleasto I'm not sure this approach is even possible without changes to virt_wifi.ko. As best I understand from my attempts to make it work earlier, the wiphy created by the module is always created in the default (host) namespace and doesn't support being moved to the container namespace. Since the wiphy (with VirtWifi SSID, etc.) ends up on the host, at best you achieve nothing for the container and at worst you break the host's Wi-Fi connection. |
|
Hello there, I have got |
|
Could anyone here help me test waydroid/waydroid#2211? (Procedures are listed in waydroid/waydroid#2211 (comment)) |
8 participants
@warlice it will need some testing first