Skip to content

Replace time.After with a timer created only once for a function call. #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexeykiselev wants to merge 14 commits into
base: master
Choose a base branch
from

Merge branch 'master' into fix-semgrep-issues-2

c4853c3
Select commit
Loading
Failed to load commit list.
Open

Replace time.After with a timer created only once for a function call. #1966

Merge branch 'master' into fix-semgrep-issues-2
c4853c3
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Semgrep OSS succeeded Apr 20, 2026 in 3s

4 new alerts

New alerts in code changed by this pull request

  • 3 warnings
  • 1 note

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 24 in .semgrepignore

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: generic.ci.audit.changed-semgrepignore.changed-semgrepignore Warning

itests/config/template.conf has been added to the .semgrepignore list of ignored paths. Someone from app-sec may want to audit these changes.

Check warning on line 27 in .semgrepignore

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: generic.ci.audit.changed-semgrepignore.changed-semgrepignore Warning

**/*.pb.go has been added to the .semgrepignore list of ignored paths. Someone from app-sec may want to audit these changes.

Check warning on line 27 in .semgrepignore

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: generic.ci.audit.changed-semgrepignore.changed-semgrepignore Warning

**/*.gen.go has been added to the .semgrepignore list of ignored paths. Someone from app-sec may want to audit these changes.

Check notice on line 3519 in pkg/ride/tree_evaluation_test.go

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: generic.secrets.gitleaks.generic-api-key.generic-api-key Note test

A gitleaks generic-api-key was detected which attempts to identify hard-coded credentials. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module). This rule can introduce a lot of false positives, it is not recommended to be used in PR comments.