Catch error event when multicastdns emit some error#49
Open
feichao wants to merge 2 commits intowatson:masterfrom
Open
Catch error event when multicastdns emit some error#49feichao wants to merge 2 commits intowatson:masterfrom
feichao wants to merge 2 commits intowatson:masterfrom
Conversation
added 2 commits
June 22, 2018 11:13
|
this would be nice! @watson |
|
This issue is caused by Another way to fix this is to not emit from the service, but from bonjour |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used in Electron, there is no way to catch some internal
multicastdnserror, when some error occurs, the main thread is crashed. This PR adds a default error callback when user not provide.