Skip to content

Allow Bonjour.JS to be used in Electron renderer #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soundprojects wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow Bonjour.JS to be used in Electron renderer #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7820b59
f
Aug 1, 2017
d8e593a
fixed test results
Aug 6, 2017
f7c18e2
push version
Sep 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 22 additions & 19 deletions lib/registry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ function probe (mdns, service, cb) {
// just silently ignore it and retry as we normally would
sent = true
timer = setTimeout(++retries < 3 ? send : done, 250)
timer.unref()

// Call this function twice to make bonjour compatible with client side Electron
timer.unref && timer.unref()
})
}

Expand Down Expand Up @@ -132,24 +134,25 @@ function announce (server, service) {

server.register(packet)

;(function broadcast () {
// abort if the service have or is being stopped in the meantime
if (!service._activated || service._destroyed) return

server.mdns.respond(packet, function () {
// This function will optionally be called with an error object. We'll
// just silently ignore it and retry as we normally would
if (!service.published) {
service._activated = true
service.published = true
service.emit('up')
}
delay = delay * REANNOUNCE_FACTOR
if (delay < REANNOUNCE_MAX_MS && !service._destroyed) {
setTimeout(broadcast, delay).unref()
}
})
})()
; (function broadcast () {
// abort if the service have or is being stopped in the meantime
if (!service._activated || service._destroyed) return

server.mdns.respond(packet, function () {
// This function will optionally be called with an error object. We'll
// just silently ignore it and retry as we normally would
if (!service.published) {
service._activated = true
service.published = true
service.emit('up')
}
delay = delay * REANNOUNCE_FACTOR
if (delay < REANNOUNCE_MAX_MS && !service._destroyed) {
// Call this function twice to make bonjour compatible with client side Electron
setTimeout(broadcast, delay).unref && setTimeout(broadcast, delay).unref()
}
})
})()
}

/**
Expand Down
Loading