Skip to content

fix(weave): exclude media payloads from agent chat text - #7660

Merged
rgao-coreweave merged 3 commits into
masterfrom
rgao/fix-agent-chat-media-text
Jul 30, 2026
Merged

fix(weave): exclude media payloads from agent chat text#7660
rgao-coreweave merged 3 commits into
masterfrom
rgao/fix-agent-chat-media-text

Conversation

@rgao-coreweave

@rgao-coreweave rgao-coreweave commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep blob, URI, and file media parts out of visible Agents chat text.
  • Continue surfacing stored Weave Content references through content_refs.
  • Add regression coverage for an image blob whose base64 payload is replaced by a Content ref at ingest.
image

Testing

  • uv run --group test python -m pytest tests/integrations/claude_agent_sdk/claude_agent_sdk_otel_test.py tests/trace_server/test_genai_chat_view.py -q (73 passed, 1 existing xfailed)
  • Targeted Ruff check and format verification passed.
  • nox --no-install -e lint: ty, import-linter, pyright, and mypy passed; Ruff hooks were blocked by an unrelated local .git remote-ref filename issue.

Breaking changes

None. Stored trace data and API schemas are unchanged.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
weave/trace_server/agents/chat_view.py 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rgao-coreweave
rgao-coreweave changed the base branch from master to graphite-base/7660 July 29, 2026 20:19
@rgao-coreweave
rgao-coreweave force-pushed the rgao/fix-agent-chat-media-text branch from 72e65d3 to a3e9bbd Compare July 29, 2026 20:19
@rgao-coreweave
rgao-coreweave changed the base branch from graphite-base/7660 to rgao/claude-agent-sdk-python-multimedia July 29, 2026 20:19

rgao-coreweave commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@w-b-hivemind

w-b-hivemind Bot commented Jul 29, 2026

Copy link
Copy Markdown

HiveMind Sessions

1 session · 43m · $22

Session Agent Duration Tokens Cost Lines
Claude Agent SDK PR Cleanup and Improvement
019fafc5-6609-7c81-a737-a8fefe4d2d49
codex 43m 1.0M $22 +513 -84
Total 43m 1.0M $22 +513 -84

View all sessions in HiveMind →

Run codex resume 019fafc5-6609-7c81-a737-a8fefe4d2d49 to pickup where you left off.

@rgao-coreweave
rgao-coreweave force-pushed the rgao/claude-agent-sdk-python-multimedia branch 2 times, most recently from 914f2e4 to 621ff74 Compare July 29, 2026 22:28
Base automatically changed from rgao/claude-agent-sdk-python-multimedia to master July 29, 2026 22:37
@rgao-coreweave
rgao-coreweave force-pushed the rgao/fix-agent-chat-media-text branch from a3e9bbd to a42d3dd Compare July 29, 2026 23:20
@rgao-coreweave
rgao-coreweave marked this pull request as ready for review July 29, 2026 23:22
@rgao-coreweave
rgao-coreweave requested a review from a team as a code owner July 29, 2026 23:22
@rgao-coreweave
rgao-coreweave requested a review from a team July 29, 2026 23:22
Comment thread AGENTS.md Outdated
Comment thread weave/trace_server/agents/chat_view.py Outdated
@rgao-coreweave
rgao-coreweave merged commit 8e40b1f into master Jul 30, 2026
109 of 110 checks passed
@rgao-coreweave
rgao-coreweave deleted the rgao/fix-agent-chat-media-text branch July 30, 2026 19:42
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants