Skip to content

feat(weave_ts): add provider name to turns - #7655

Closed
rgao-coreweave wants to merge 1 commit into
masterfrom
rgao/typescript-turn-provider-name
Closed

feat(weave_ts): add provider name to turns#7655
rgao-coreweave wants to merge 1 commit into
masterfrom
rgao/typescript-turn-provider-name

Conversation

@rgao-coreweave

Copy link
Copy Markdown
Contributor

Summary

  • add optional typed providerName state to the TypeScript Turn API
  • accept it through startTurn() / Conversation.startTurn() and Turn.record()
  • emit it as gen_ai.provider.name on the root invoke_agent span at Turn.end()
  • update the Claude Agent SDK integration to pass providerName when creating its turn instead of calling setAttributes()
  • cover initial, recorded, and preserved provider values in Turn tests

Testing

  • pnpm exec jest --runInBand src/__tests__/genai/turn.test.ts src/__tests__/integrations/claude-agent-sdk/otelTracer.test.ts — 25 passed
  • pnpm test — 455 passed
  • pnpm run typecheck:cjs — passed
  • pnpm run typecheck:esm — passed
  • pnpm run prettier-check — passed
  • targeted ESLint — passed

Breaking changes

None. providerName is optional and defaults to an empty string.

Related

TypeScript parity for the Python Turn provider support in #7654. This PR is independent and based directly on master.

@rgao-coreweave
rgao-coreweave requested review from a team as code owners July 29, 2026 00:02
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant