fix: Upgrade Grafana Operator to 5.22.2 - #275
Conversation
📝 WalkthroughWalkthroughThe Helm chart version was updated to ChangesHelm chart release
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@deploy/operator/Chart.yaml`:
- Line 5: Update the appVersion field in Chart.yaml to 2.0.0-beta.2 so it
matches the chart version and operator image tag.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3d10aaf3-26b5-4e6f-a17b-ce803a74af40
⛔ Files ignored due to path filters (1)
deploy/operator/Chart.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
deploy/operator/Chart.yaml
| description: A Helm chart for Weights & Biases operator | ||
| type: application | ||
| version: 2.0.0-beta.1 | ||
| version: 2.0.0-beta.2 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
make lint
make testRepository: wandb/operator
Length of output: 194
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
printf '\n== Chart.yaml ==\n'
cat -n deploy/operator/Chart.yaml
printf '\n== Chart.lock ==\n'
cat -n deploy/operator/Chart.lock
printf '\n== version-related docs ==\n'
rg -n --hidden --glob '!**/.git/**' -e 'appVersion|chart version|version together|release metadata|operator versions' README.md docs deploy/operator .github || trueRepository: wandb/operator
Length of output: 4097
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
printf '\n== docs/releasing.md ==\n'
sed -n '1,40p' docs/releasing.md
printf '\n== .github/workflows/release.yaml ==\n'
sed -n '55,85p' .github/workflows/release.yaml
printf '\n== .github/workflows/internal-chart-publish.yaml ==\n'
sed -n '1,95p' .github/workflows/internal-chart-publish.yamlRepository: wandb/operator
Length of output: 6274
Align appVersion with the chart version
deploy/operator/Chart.yaml:5-6 — bump appVersion to 2.0.0-beta.2 as well. The release workflow expects version, appVersion, and the operator image tag to match.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@deploy/operator/Chart.yaml` at line 5, Update the appVersion field in
Chart.yaml to 2.0.0-beta.2 so it matches the chart version and operator image
tag.
Source: Coding guidelines
| description: A Helm chart for Weights & Biases operator | ||
| type: application | ||
| version: 2.0.0-beta.1 | ||
| version: 2.0.0-beta.2 |
There was a problem hiding this comment.
| version: 2.0.0-beta.2 | |
| version: 2.0.0-beta.1 |
Summary
Upgrade the embedded Grafana Operator Helm dependency from 5.21.4 to 5.22.2, bump the W&B Operator Helm chart package to
2.0.0-beta.2, and regeneratedeploy/operator/Chart.lock.Root cause
Grafana Operator 5.21.4 ships the
GrafanaNotificationPolicyCRD with the CEL rule!has(self.continue). On Kubernetes 1.30,continueis parsed as a CEL keyword, so the API server rejects the CRD during a full-telemetry install. Grafana Operator 5.22.2 includes the upstream fix to address the field asself.__continue__.Upstream fix: grafana/grafana-operator#2583
Impact
Full-telemetry installations can install the Grafana notification-policy CRD on Kubernetes 1.30 without requiring a WSM-side mutation of a packaged dependency.
The chart package version is
2.0.0-beta.2. ItsappVersionand operator image remain2.0.0-beta.1because this fix changes only the packaged Helm dependency, not the controller binary. WSM/Watchtower must select chart2.0.0-beta.2before existing consumers receive the fix.Published artifact
oci://us-docker.pkg.dev/wandb-production/public/wandb/charts/operator:2.0.0-beta.2sha256:e3619e2a607928594af8cea449863477aa8244d112fa5b584353f0efd668746fValidation
helm dependency build --skip-refresh deploy/operatorhelm lint --strict deploy/operator --values deploy/operator/profiles/telemetry-full.yaml--include-crdsand verified the rule is!has(self.__continue__)kubectl apply --dry-run=serveragainst the affected EKS Kubernetes 1.30 API serverSummary by CodeRabbit