Skip to content

feat(backend): Unify labels for pods - #236

Open
wnevis-cmyk wants to merge 2 commits into
v2from
wnevis/unifyLabels
Open

feat(backend): Unify labels for pods#236
wnevis-cmyk wants to merge 2 commits into
v2from
wnevis/unifyLabels

Conversation

@wnevis-cmyk

Copy link
Copy Markdown
Contributor
  • Standardizes labels for pods
  • Tested with wandb verify
  • Adds documentation describing labeling scheme

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: acfeda1c-997a-4f9d-ad7a-b9f37bfe1f8c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch wnevis/unifyLabels

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@wnevis-cmyk wnevis-cmyk changed the title Unify labels for pods feat(backend): unify labels for pods Jul 8, 2026
@wnevis-cmyk wnevis-cmyk changed the title feat(backend): unify labels for pods feat(backend): Unify labels for pods Jul 8, 2026
@wnevis-cmyk

Copy link
Copy Markdown
Contributor Author

Totally happy to scrap the doc, but I thought it'd be a little easier than digging through the code

Comment on lines +47 to +55
var appComponentRoles = map[string]string{
"executor": RoleWorker,
"parquet": RoleWorker,
"weave-trace-worker": RoleWorker,
"weave-trace-evaluate-model-worker": RoleWorker,
"flat-run-fields-updater": RoleWorker,
"metric-observer": RoleWorker,
"nginx-proxy": RoleProxy,
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid hard-coding these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants