Skip to content

Added failed login checks#24

Open
runaroundhome wants to merge 5 commits into
walkrflocka:devfrom
runaroundhome:patch-3
Open

Added failed login checks#24
runaroundhome wants to merge 5 commits into
walkrflocka:devfrom
runaroundhome:patch-3

Conversation

@runaroundhome

Copy link
Copy Markdown

And specific check if IP may be banned. (not always obvious when setting up on remote seedbox)

I had no clue how to resolve the conflicts, seemed to be due to dir change, but it just said "These conflicts are too complex to resolve in the web editor." and I don't see how to fix it via GitHub Desktop, and don't use command line git enough to fix it that way.
So here's a 2nd pull request... I mean 3rd.. Sorry for the mess.

I just manually tested it. My ip was banned so I ran the script and confirmed the code worked. I also tried to login without a 2FA code and confirmed I got the "Login failed with warning" log error.
That's about all the testing I did.

And specific check if IP may be banned. (not always obvious when setting up on remote seedbox)
@walkrflocka

Copy link
Copy Markdown
Owner

Hey @runaroundhome sorry for taking so long but your LoginException seems to not exist, please correct this

Also - 200 generally denotes a successful response, are you sure that that's the HTTP code we should be checking for? I would expect that OPS would send a different code back than an OK if there were an issue with the TOTP etc.

@runaroundhome

Copy link
Copy Markdown
Author

Oops, added the LoginException class, not sure why it was MIA.

Yeah 200 is unusual for a failed login, but that's what I observed. The script would try to continue on thinking all was well, but then fail, I check'ed the html response, which is where I found the 2FA error message.

I'm hesitant to test (wrong 2FA) login again, as it seems like ops bans my IP pretty quick after failing auth these days. I've already annoyed staff quite a bit recently about unbanning my IP.

@walkrflocka walkrflocka added the enhancement New feature or request label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants