fix(server): add missing SetScreen method to BrowserWindow

[leaanthony]

Closes #5262.

BrowserWindow was missing SetScreen(screen *Screen) Window, which was added to the Window interface in #5067. This caused a compile error when building with -tags server.

The fix follows the existing no-op pattern for methods that have no meaning for browser clients.

Verified: go build -tags server ./v3/pkg/application/ and go build -tags server ./v3/examples/dock/ both pass.

Summary by CodeRabbit

• New Features
  • Browser windows now support the SetScreen method for configuring screen settings. The method returns the window instance, enabling method chaining patterns for fluent API usage. This provides developers with a more flexible and integrated approach to window and screen configuration.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5df405f4-fbb9-410f-8383-fe21de1c389e

📥 Commits

Reviewing files that changed from the base of the PR and between bd6b326 and 87db663.

📒 Files selected for processing (1)

• v3/pkg/application/browser_window.go

---

Walkthrough

A no-op SetScreen method is added to BrowserWindow to satisfy the Window interface updated in a prior change. This resolves compilation failures when building with -tags server.

Changes

Interface Implementation

Layer / File(s)	Summary
Method Addition v3/pkg/application/browser_window.go	BrowserWindow.SetScreen(screen *Screen) Window is added, returning the receiver to satisfy the updated Window interface. Browser windows have no notion of physical screens, so this is a no-op implementation consistent with existing patterns in the file.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested Labels

Bug, size:M

Suggested Reviewers

• atterpac

Poem

A rabbit hops through code so fine,
One method mends the broken line,
SetScreen now greets the Window's call,
No screen to set for none at all! 🐰✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: adding the missing SetScreen method to BrowserWindow to fix server-mode builds.
Description check	✅ Passed	The description directly addresses the issue, explains the problem and solution, references the linked issue (#5262), and documents verification steps. All critical information is present.
Linked Issues check	✅ Passed	The PR directly fixes issue #5262 by adding the missing SetScreen method to BrowserWindow, resolving the compile error for server-mode builds as required.
Out of Scope Changes check	✅ Passed	The single change adding the SetScreen method is directly scoped to fixing the server-mode build failure described in issue #5262. No out-of-scope modifications are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch agent/engineer-mac/a7063950

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Adds the missing SetScreen(*Screen) Window method to the server-mode BrowserWindow so it satisfies the Window interface when building with -tags server (fixing the compile break introduced when SetScreen was added to the interface).

Changes:

• Implement BrowserWindow.SetScreen(screen *Screen) Window as a no-op that returns the receiver (consistent with other browser-window no-op methods).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.