fix(v2): strip ANSI escape sequences and use LC_ALL=C in apt PackageInstalled#5184
Draft
leaanthony wants to merge 2 commits intomasterfrom
Draft
fix(v2): strip ANSI escape sequences and use LC_ALL=C in apt PackageInstalled#5184leaanthony wants to merge 2 commits intomasterfrom
leaanthony wants to merge 2 commits intomasterfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… check Tests revealed that strings.Contains(output, "[installed]") fails for apt variants like [installed,local] and [installed,automatic] because the closing bracket doesn't match. Changed to search for "[installed" (without closing bracket) to match all installed-state variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
wails doctorincorrectly reportslibgtk-3-devandlibwebkit2gtk-4.0-devas not installed on some Debian/Ubuntu systems whereapt list -qqoutput includes ANSI escape codes or the locale is non-English.Closes #4258
Changes
apt listoutput inPackageInstalled(using the existingremoveEscapeSequencesmethod already used byPackageAvailable)LANGUAGE=enwithLC_ALL=Cfor more robust locale forcingTesting
removeEscapeSequencesregex correctly strips ANSI codes from colored apt outputstrings.Containscheck for[installed]already handles all variants:[installed],[installed,local],[installed,automatic],[installed,upgradable to: X.Y.Z]