feat: add FullscreenButtonState to WebviewWindowOptions for API consistency#5183
Draft
leaanthony wants to merge 1 commit intomasterfrom
Draft
feat: add FullscreenButtonState to WebviewWindowOptions for API consistency#5183leaanthony wants to merge 1 commit intomasterfrom
leaanthony wants to merge 1 commit intomasterfrom
Conversation
…stency The window options struct defines button states using ButtonState for minimise, maximize, and close buttons, but the fullscreen button used setFullscreenButtonEnabled(bool) with a simple bool. This adds FullscreenButtonState ButtonState to the options struct for consistency. Changes: - Add FullscreenButtonState ButtonState to WebviewWindowOptions - Update macOS C code to use setButtonState pattern (supports enabled/disabled/hidden instead of just enabled/disabled) - Add setFullscreenButtonState to all platform implementations - Apply FullscreenButtonState during window initialization on macOS and Windows (no-op on Linux/iOS/Android) - Keep setFullscreenButtonEnabled(bool) for backward compatibility Fixes #4967
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
FullscreenButtonState ButtonStatetoWebviewWindowOptionsfor consistency with the existingMinimiseButtonState,MaximiseButtonState, andCloseButtonStatefields.Previously, the fullscreen button used
setFullscreenButtonEnabled(bool)with a simple bool, while all other titlebar buttons used theButtonStatetype (Enabled/Disabled/Hidden).Changes:
FullscreenButtonState ButtonStatetoWebviewWindowOptionssetFullscreenButtonEnabled(bool)tosetFullscreenButtonState(int)using the samesetButtonStatepattern as other buttons — now supports Hidden state toosetFullscreenButtonState(ButtonState)to all platform implementations (Linux, Windows, iOS, Android)FullscreenButtonStateduring window initialization on macOS and WindowssetFullscreenButtonEnabled(bool)for backward compatibilityFiles changed:
webview_window_options.go— new option fieldwebview_window_darwin.go— C code + Go wrapper updatedwebview_window_linux.go— new stubwebview_window_windows.go— new stub + initwebview_window_ios.go— new stubwebview_window_android.go— new stubFixes #4967
Type of change
How Has This Been Tested?
go build ./pkg/application/compiles cleanly on LinuxChecklist: