fix(linux): preserve display name in .desktop file generation#5182
Draft
leaanthony wants to merge 1 commit intomasterfrom
Draft
fix(linux): preserve display name in .desktop file generation#5182leaanthony wants to merge 1 commit intomasterfrom
leaanthony wants to merge 1 commit intomasterfrom
Conversation
GenerateDotDesktop was calling normaliseName() on the Name field, which lowercased it and replaced spaces with dashes. This altered the Name= value in the .desktop entry, affecting how the app appears in desktop menus. The Name field in a .desktop file should be the human-readable display name per the FreeDesktop spec. Only the output filename needs to be normalized. Before: wails3 generate .desktop -name "My app" → Name=my-app After: wails3 generate .desktop -name "My app" → Name=My app Fixes #5072
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GenerateDotDesktopwas callingnormaliseName()on theNamefield, which lowercased it and replaced spaces with dashes. This altered theName=value in the generated.desktopentry, affecting how the app appears in Linux desktop menus.The
Namefield in a.desktopfile should be the human-readable display name per the FreeDesktop spec. Only the output filename needs to be normalized.Before:
After:
Fixes #5072
Type of change
How Has This Been Tested?
Checklist: