fix(darwin): update minimum macOS version from 10.15 to 12.0#5181
Draft
leaanthony wants to merge 1 commit intomasterfrom
Draft
fix(darwin): update minimum macOS version from 10.15 to 12.0#5181leaanthony wants to merge 1 commit intomasterfrom
leaanthony wants to merge 1 commit intomasterfrom
Conversation
Since Go 1.25, the linker embeds LC_BUILD_VERSION with minos 12.0 into Mach-O binaries, meaning apps physically cannot run on macOS < 12. The mismatch between LSMinimumSystemVersion (10.15) and the actual binary minimum (12.0) caused apps to silently crash on older macOS with no error dialog. Updating to 12.0 ensures macOS shows a clear dialog: "MyApp requires macOS 12 or later." Updated: - Info.plist.tmpl / Info.dev.plist.tmpl (LSMinimumSystemVersion) - build_assets/darwin/Taskfile.yml (CGO flags, MACOSX_DEPLOYMENT_TARGET) - All example build files for consistency Runtime @available checks and version name maps are unchanged. Fixes #5161
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the minimum macOS deployment target from 10.15 (Catalina) to 12.0 (Monterey) in build templates and example projects.
Since Go 1.25, the linker embeds
LC_BUILD_VERSIONwithminos 12.0into Mach-O binaries. This means apps built with Go 1.25+ physically cannot run on macOS < 12. The mismatch betweenLSMinimumSystemVersion(10.15) and the actual binary minimum (12.0) caused apps to silently crash on older macOS with no error dialog.Setting
LSMinimumSystemVersionto 12.0 ensures macOS shows a clear dialog: "MyApp" requires macOS 12 or later.Files updated:
updatable_build_assets/darwin/Info.plist.tmpl+Info.dev.plist.tmpl(LSMinimumSystemVersion)build_assets/darwin/Taskfile.yml(CGO_CFLAGS,CGO_LDFLAGS,MACOSX_DEPLOYMENT_TARGET)Not changed: Runtime
@available(macOS 10.15, *)guards and the version name map inos_darwin.go— these are feature detection checks, not minimum version declarations.Fixes #5161
Type of change
How Has This Been Tested?
Checklist: