Delve debugging#5137
Conversation
… of `e.Taskfile.Vars` to make sure variables are injected earlier in the lifecycle
…t `atterpac/refresh` config. This in turn runs delve in headless mode waiting for debugger to connect before starting the wails app. Auto-reload is still present but, it does mean reconnecting to delve on change
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note that when you run IntelliJ - Use "Run -> Add Configuration," choose "Go Remote," and specify the host and port. |
|
comment to link #5138 because Github is flakier than Winter snow these days |
|
🔍 Triaged by Wails PR Reviewer - Awaiting Feedback This PR has been reviewed and looks interesting, but I have some questions before proceeding:
Head Ref OID: This comment serves as a signature that this PR has been triaged. Future runs will skip this PR based on the headRefOid. |
|
Thanks for this PR! You mentioned in the description that you'd like to tidy up the code before marking it as ready. Please update the PR when it's ready for review, and consider adding tests and updating the documentation if needed. |
|
I see you mentioned this PR is quite messy and you'd like to tidy it up before marking it as ready, and that you want to get some feedback first. Could you share:
Once you've addressed these and marked the PR as ready for review, I'll take another look. |
|
hey there, sorry about the delay in responding; been quite a busy chap! Scraping my mind a bit The cleanupIn Feedback requestedThis was really just asking people to make sure it isn't broken on different setups and secondly if there are any extra options people would want to include such as wait on debugger, debugger port, and other Delve options ConcernsReally just about the way the refresh spec is pieced together from a maintainability point of view. i will try to make some time to spend with v3 in about a week and can happily implement the changes and try to help with other stuff |
|
Thanks for working on this! Debugging support would be a valuable addition to Wails v3. You mentioned that you'd like to tidy up the code before marking it as ready. When you've done that, please update this PR with:
Feel free to ping me when you've updated the PR and I'll take another look! Decision: COMMENT-AND-WAIT - Awaiting code cleanup and additional information CC @leaanthony |
Adds a
debugsub command which in turn executes the wails app using delve waiting for a debugger session.I would like to tidy the code up a bit further before marking this as ready after getting some feedback. It is quite messy because it was an investigation in to the workings of wailsv3 at the same time