Add activation to simulator#420
Open
apasel422 wants to merge 1 commit into
Open
Conversation
geejlyn76-max
approved these changes
May 18, 2026
martinthomson
requested changes
May 29, 2026
Member
martinthomson
left a comment
martinthomson
left a comment
There was a problem hiding this comment.
Approval pending, but I think that you need to use the navigation hook before this is done.
| "event": "saveImpression", | ||
| "topLevelTraversable": "a", | ||
| "options": { "histogramIndex": 1 }, | ||
| "expectedError": { |
Member
There was a problem hiding this comment.
expectedError here, expected below ??!?
| "topLevelTraversable": "b" | ||
| }, | ||
| { | ||
| "seconds": 2004, |
Member
There was a problem hiding this comment.
This works because the time is exactly 1000 seconds, yes? And the conversion measurement works at 1001 seconds because of the flag.
| "maxValue": 10 | ||
| }, | ||
| "expected": [0, 5, 0] | ||
| } |
Member
There was a problem hiding this comment.
I would add a cross-site navigation on "b" here to demonstrate that the errors start back up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.