Refactor AlphabrowseController to an action.#5277
Open
EreMaijala wants to merge 1 commit into
Open
Conversation
demiankatz
changed the title
demiankatz
added
the
architecture
demiankatz
requested changes
May 12, 2026
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Also haven't had time to look at this extremely closely, but see below for a quick first impression.
| protected function applyTopicDelimiters(&$result): void | ||
| { | ||
| $config = $this->getConfigArray(); | ||
| $config = $this->config; |
Member
There was a problem hiding this comment.
Maybe it's cleaner to just use $this->config in line 279 below; this assignment doesn't really seem necessary.
| * @return void | ||
| */ | ||
| protected function applyHighlighting(ViewModel $view, int $rowsBefore): void | ||
| protected function applyHighlighting(array &$templateParams, int $rowsBefore): void |
Member
There was a problem hiding this comment.
Would it make sense to have this function return the modified array instead of changing it by reference? I don't have a strong preference, but I try to avoid manipulation by reference when feasible since it can be a little less clear.
(And, of course, same question applies to addResultsToTemplateParams above).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a relatively straightforward conversion. I eliminated the need for AlphaBrowseTrait because it didn't add much, and the new call style is easier to follow.