Refactor AjaxController to actions.#5276
Open
EreMaijala wants to merge 1 commit into
Open
Conversation
demiankatz
added
the
architecture
demiankatz
requested changes
May 12, 2026
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
I haven't had time to look at all of this yet, but a couple of quick observations...
| * @param ResponseInterface $response Response object | ||
| * @param ?string $template Template name, or null to use default for the action | ||
| * @param array $params Template parameters | ||
| * @param array $childTemplates Any child templates; an associative array with keys 'template' and |
Member
There was a problem hiding this comment.
Would it be more clear to say "an array of associative arrays" and to make the type array[]? If so, we'll have to change this in a few places (both methods in this interface, and also in the implementation).
| * | ||
| * @return bool | ||
| * | ||
| * @SuppressWarnings(PHPMD.UnusedFormalParameter) |
Member
There was a problem hiding this comment.
Why is this annotation being removed? I think it's still true...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to keep the changes to minimum while reducing dependency on Laminas MVC. The following changes were made throughout the AJAX handlers:
display_errors.