Skip to content

Display 'no call number' when appropriate. #5270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
demiankatz wants to merge 1 commit into
base: dev
Choose a base branch
from
+4 −1
Open

Display 'no call number' when appropriate. #5270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions languages/en.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,6 +932,7 @@ Newspaper = "Newspaper"
Next = "Next"
Next Search Result = "Next Search Result"
NLM Title Abbreviation = "NLM Title Abbreviation"
No call number = "No call number"
No citations are available for this record = "No citations are available for this record"
No Comments = "No Comments"
No Cover Image = "No Cover Image"
Expand Down
4 changes: 3 additions & 1 deletion themes/bootstrap5/templates/ajax/itemCallnumber.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<?php if ($this->callnumberHandler): ?>
<?php if (strlen($this->displayCallnumber ?? '') === 0): ?>
Copy link
Copy Markdown
Contributor

@EreMaijala EreMaijala May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<?php if (strlen($this->displayCallnumber ?? '') === 0): ?>
<?php if ('' === (string)($this->displayCallnumber ?? '')): ?>

Copy link
Copy Markdown
Contributor

@EreMaijala EreMaijala May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe even trim instead of cast?

<?=$this->transEsc('No call number') ?>
<?php elseif ($this->callnumberHandler): ?>
<?php
$url = $this->url('alphabrowse-home') . '?' . http_build_query([
'source' => $this->callnumberHandler,
Expand Down
Loading