Fix ZoteroService.php cleanupRecords()#5266
Open
gyetger wants to merge 2 commits into
Open
Conversation
Fix creators being always removed from the object Fix bug by using object property access instead of array access
Member
|
Thanks for the fix, @gyetger! @EreMaijala, since you're more familiar with Zotero than I am, do you mind taking a look at this? Please let me know if you think this should be backported for release 11.0.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"creators" is not defined in the Zotero schema as a field, so the current code always removes it. I fix this by skipping that field.
Leaving "creators" in the object introduces a bug.
"$creator->creatorType" must be used instead of "$creator['creatorType']" since it is an object.