Add support for GVI#5064
Conversation
| * | ||
| * @var array | ||
| */ | ||
| protected array $defaultFacetLabelSections = [ |
There was a problem hiding this comment.
The dev branch needs this declaration without array.
| * | ||
| * @var string | ||
| */ | ||
| protected string $backendId = 'GVI'; |
There was a problem hiding this comment.
The dev branch needs this declaration without string.
| * | ||
| * @var string | ||
| */ | ||
| protected string $searchIni = 'GVI'; |
There was a problem hiding this comment.
The dev branch needs this declaration without string.
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @stweil, this seems like a reasonable start! See below for a few minor notes.
Another important thing to keep in mind is that, because of the laminas-mvc deprecation, we'll likely be eliminating controllers in the coming months, which will have some (hopefully easy-to-fix) impact on this PR. I see that you have noted some of the typing differences between the dev and dev-12.0 branches in your comments here. It would be a good idea to think about the timeline for completing this work, so we can decide whether to target it against the dev branch for inclusion in 11.1, or to keep it here for inclusion in 12.0. (I have no strong feelings one way or the other -- but if you plan to complete this, it would be helpful to set some goals about timeline for planning purposes).
| { | ||
| parent::__construct(); | ||
| $this->mainConfig = $this->searchConfig = $this->facetConfig = 'GVI'; | ||
| $this->searchYaml = 'searchspecs2.yaml'; |
There was a problem hiding this comment.
Does GVI need its own searchspecs file?
Is this something which we can discuss in the next community call? I expect that some more people from the German VuFind community will be present there. I still don't know whether / when my library will switch to VuFind. Therefore it is not very important for me whether the target is 11.1 or 12.0. |
Sure, I'll bring it up at next week's meeting to see if people have strong feelings, but I suspect that 12.0 will prove to be a reasonable target, if you're not in a hurry yourself. |
Now displays language, published, online access, summary, series, subjects.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2 participants
The German "Gemeinsamer Verbündeindex" (GVI) is used by many German libraries for interlibrary loans.
It is an external Solr index containing MARC21 record data in the 'fullrecord' field.
This is my first experimental implementation based on copies from Search2.
It is a draft for further discussion and is not yet ready for merging because a number of issues still need to be resolved:
fullrecordfullrecordComments and suggestions are very welcome.