Refactor the DefaultParametersListener test for readability#5042
Merged
demiankatz merged 6 commits intoJan 29, 2026
Merged
Conversation
maccabeelevine
commented
Jan 28, 2026
7 tasks
demiankatz
requested changes
Jan 29, 2026
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @maccabeelevine, this is definitely a lot more readable now. See below for a couple of minor suggestions.
Member
|
Might also be worth rebasing this to release-11.0 so the config documentation improvement can be included along with the bug fix. (As before, I'm happy to help with that if you have any trouble). |
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
maccabeelevine
force-pushed
the
refactor-default-parameter-listener-test
branch
from
4ae9d10 to
6de8972
Compare
demiankatz
requested changes
Jan 29, 2026
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @maccabeelevine, the rebase looks good. One more question, though!
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
demiankatz
approved these changes
Jan 29, 2026
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @maccabeelevine, I believe everything is in order now!
ckaz
pushed a commit
to finc/vufind
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I meant to do this (as @demiankatz suggested) as part of #5013, but pushed it to the wrong PR before #5013 was merged. While I'm doing it again, I decided to do a more thorough job.